aws-efs-csi-driver
aws-efs-csi-driver copied to clipboard
kubernetes-sigs
feat(node/controller): allow to set updateStrategy
Is this a bug fix or adding new feature?
(New Feature)
This PR allow to define updateStrategy for controller deployment and node daemonset
What is this PR about? / Why do we need it? With default update strategy takes too long to update all the pods of the daemonset if you have many worker nodes. This results in helm timeout (after 300 second.)
We would like to have the option to tune the updateStrategy if needed. Selecting different updateStrategy type or tuning the defaultRollingUpdate.
ps: I see there is an open PR already about it, but since is a bit old ,not sure if someone is still working on it. If that can be merged i can close mine.
Welcome @lefterisALEX!
It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @lefterisALEX. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@Ashley-wenyizha @RomanBednar @jonathanrainer @makomatic could you please take a look?
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: lefterisALEX
Once this PR has been reviewed and has the lgtm label, please ask for approval from jqmichael by writing /assign @jqmichael in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@lefterisALEX could you please integrate/review @RomanBednar suggestions for the PR? And maybe rebase your branch.
@RomanBednar your reviews have been integrated, can you take a look again?
@RomanBednar can you please take a look again to the latest commit?
Thank you for the patch, I added lgtm label but we still need someone who can approve/merge changes.
rebase and squash commits. @RomanBednar @jqmichael can you please review?
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: lefterisALEX, pierluigilenoci
Once this PR has been reviewed and has the lgtm label, please ask for approval from jqmichael by writing /assign @jqmichael in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@wongma7 @jqmichael i will really appreciate if you can take a look into that ;)