aws-efs-csi-driver icon indicating copy to clipboard operation
aws-efs-csi-driver copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Adding ability to set volMetricsOptIn on Daemonset

Open jonathanrainer opened this issue 2 years ago • 3 comments

Is this a bug fix or adding new feature? This is a bug-fix in response to #698.

What is this PR about? / Why do we need it? It seems as though volMetricsOptIn is set for the controller container when the code that uses the flag isn't executed in that context. I've added the flag to the daemonset as well in the first instance because I'm not 100% sure that the flag is never used in the context of the controller. If that is the case I'm happy to also delete those settings in a separate commit.

What testing is done? As this is a helm change that is very simple, and replicates code that already exists in the codebase, this is untested other than the automated tests that run as part of the PR. However if there are further tests you would like performing I'm happy to do so.

fixes #698

jonathanrainer avatar May 28 '22 05:05 jonathanrainer

Hi @jonathanrainer. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar May 28 '22 05:05 k8s-ci-robot

Hey, this change looks simple enough. Can it be reviewed?

z0rc avatar Sep 08 '22 07:09 z0rc

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jonathanrainer Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval by writing /assign @justinsb in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 30 '22 21:09 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 29 '22 21:12 k8s-triage-robot

/remove-lifecycle stale

z0rc avatar Dec 30 '22 10:12 z0rc

/ok-to-test

makomatic avatar Feb 02 '23 20:02 makomatic

@makomatic: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 02 '23 20:02 k8s-ci-robot

Works as expected if I use it in our QA cluster with --vol-metrics-opt-in=true as arg for the daemonset binary. kubelet_volume_stats_available_bytes is set to EFS max capacity, of course (8388607Ti), but kubelet_volume_stats_used_bytes seems to be valid.

makomatic avatar Feb 03 '23 07:02 makomatic

Hi @mskanth972 can we have an ok-to-test on this one?

jonathanrainer avatar Feb 04 '23 06:02 jonathanrainer

Any update on this one? What is still blocking?

WDaan avatar May 08 '23 11:05 WDaan

/ok-to-test

mskanth972 avatar May 08 '23 13:05 mskanth972

@jonathanrainer, thanks for the PR. Can you remove that parameter in controller helm chart in a separate commit?

mskanth972 avatar May 18 '23 13:05 mskanth972

@mskanth972 That's now done, do I need to re-generate the Kustomize as well?

jonathanrainer avatar May 18 '23 14:05 jonathanrainer

@jonathanrainer not necessary I believe but if you can that would be great.

mskanth972 avatar May 18 '23 14:05 mskanth972

@mskanth972 That's now fixed too, I also realised there was an inconsistency between the helm chart and the kustomize so that's now fixed up as well.

jonathanrainer avatar May 18 '23 14:05 jonathanrainer

Thanks @jonathanrainer, will merge it and mark in the next release.

mskanth972 avatar May 18 '23 14:05 mskanth972

/lgtm

mskanth972 avatar May 19 '23 14:05 mskanth972

/approve

mskanth972 avatar May 19 '23 14:05 mskanth972

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathanrainer, mskanth972

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 19 '23 14:05 k8s-ci-robot