aws-efs-csi-driver icon indicating copy to clipboard operation
aws-efs-csi-driver copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Feature Suggestion: Multiple EFS volumes per storage class (example implementation done)

Open artificial-aidan opened this issue 3 years ago • 17 comments

Is your feature request related to a problem? Please describe. The limit of 120 access points per EFS means there is a max number of PVCs per storage class

Describe the solution you'd like in detail Allow multiple EFS volumes per storage class

I took a stab at this and it's working in my test environment. I accepted a comma separated list of EFS Filesystem Ids, and then check to see if they have the max number of access points before using one.

Is this something that would be considered? Here is the branch in my fork that contains the changes: https://github.com/artificial-aidan/aws-efs-csi-driver/tree/aidan/multi-efs

Possible improvements:

  • Query the quota for max number of APs per filesystem instead of hardcoding it. Or at least take it in as an argument.

artificial-aidan avatar Mar 11 '22 15:03 artificial-aidan

@d-nishi what needs to be done to have this considered?

artificial-aidan avatar Apr 01 '22 22:04 artificial-aidan

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jun 30 '22 22:06 k8s-triage-robot

/remove-lifecycle stale

artificial-aidan avatar Jul 01 '22 00:07 artificial-aidan

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Sep 29 '22 00:09 k8s-triage-robot

/remove-lifecycle stale

artificial-aidan avatar Sep 29 '22 01:09 artificial-aidan

I'd love to see >120 AP supported, and this seems like a compelling approach from a usability perspective. Would be great if the MR get some attention to inform whether it's a goer from a technical or roadmap approach?

djmcgreal-cc avatar Oct 17 '22 10:10 djmcgreal-cc

FWIW I've been using this implementation since March without issues.

artificial-aidan avatar Oct 17 '22 13:10 artificial-aidan

The limit of 120 APs is a major issue for us, so I'd love to see this flexibility added to the driver. What needs to be done to get #761 reviewed?

617m4rc avatar Nov 16 '22 12:11 617m4rc

Still running this in production. It seems to be working well still.

artificial-aidan avatar Dec 23 '22 17:12 artificial-aidan

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Mar 23 '23 17:03 k8s-triage-robot

With the increase of the maximum number of APs per file system from 120 to 1000 in January, this feature request is most likely becoming obsolete.

617m4rc avatar Mar 24 '23 08:03 617m4rc

We are moving away from EFS, so I'll probably let this go stale. But over 1000 PVs is not that high in a cluster.

artificial-aidan avatar Mar 24 '23 13:03 artificial-aidan

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Apr 23 '23 14:04 k8s-triage-robot

Given its been made to work already, it seems silly to let this rot.

/remove-lifecycle rotten

techdragon avatar May 02 '23 06:05 techdragon

/kind feature

RyanStan avatar May 15 '23 15:05 RyanStan

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 20 '24 10:01 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Feb 19 '24 11:02 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Mar 20 '24 11:03 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 20 '24 11:03 k8s-ci-robot