aws-efs-csi-driver
aws-efs-csi-driver copied to clipboard
Add Storage Class to static_provisioning and statefulset examples
Is your feature request related to a problem?/Why is this needed A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
The static_provisioning and statefulset examples do not have a storageclass in the example. This may result in confusion for people when looking at these examples when all others have storageclasses.
/feature
Describe the solution you'd like in detail A clear and concise description of what you want to happen.
Add storageclass objects to the static_provisioning and statefulset examples
Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.
If there is a reason not to include these, please describe it in the readme.
Additional context Add any other context or screenshots about the feature request here.
I think I'm having difficulty with this as well. I created a static provisioned PV/PVC with an empty storageClassName. Since gp2 storage class in the EKS cluster was set as the default, this changed my PVC to use the gp2 storageClass, though it was still linked to my static provisioned PV using the EFS CSI driver. This did cause issues when trying to run kubectl apply
, as it was attempting to revert the immutable storageClassName to an empty string.
Should we create a storage class for the static provisioning method? Would it just be something like:
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
name: efs-static
provisioner: efs.csi.aws.com
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied - After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied - After 30d of inactivity since
lifecycle/rotten
was applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle stale
- Mark this issue or PR as rotten with
/lifecycle rotten
- Close this issue or PR with
/close
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied - After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied - After 30d of inactivity since
lifecycle/rotten
was applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle rotten
- Close this issue or PR with
/close
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied - After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied - After 30d of inactivity since
lifecycle/rotten
was applied, the issue is closed
You can:
- Reopen this issue or PR with
/reopen
- Mark this issue or PR as fresh with
/remove-lifecycle rotten
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
@k8s-triage-robot: Closing this issue.
In response to this:
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied- After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied- After 30d of inactivity since
lifecycle/rotten
was applied, the issue is closedYou can:
- Reopen this issue or PR with
/reopen
- Mark this issue or PR as fresh with
/remove-lifecycle rotten
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.