aws-efs-csi-driver
aws-efs-csi-driver copied to clipboard
kubernetes-sigs
Templatizing priotityClassName, hostNetwork, and additionalLabels in node-daemonset.yaml
Is this a bug fix or adding new feature? This is adding some new features to the aws-efs-csi-driver helm charts
What is this PR about? / Why do we need it? The PR is about adding changes to the aes-efs-csi-driver helm chart.
- In
node-daemonset.yaml- templatize priorityClassName
- templatize hostNetwork
- add additional labels to node-daemonset.yaml
What testing is done? yes
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: RadOctocode / name: Michelle Tan (1b966c7c5f9dd90e2ea295592a0c6ff61e822ae2, 1a692dff3beed6f6d55dd4a55ec0002287aaaaf1)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @RadOctocode!
It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @RadOctocode. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kevarr, r5sec5cyl, RadOctocode, seanzatzdev-amazon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [seanzatzdev-amazon]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Setting hostNetwork=False on the Node Daemonset will cause mounts to hang at upgrade time. See this Github issue:
https://github.com/kubernetes-sigs/aws-efs-csi-driver/issues/1270.
We are going to open a PR to revert that piece of the change.
