aws-efs-csi-driver
aws-efs-csi-driver copied to clipboard
kubernetes-sigs
feat: allow to don't use helm hooks for CSIDriver creation
Is this a bug fix or adding new feature?
Fixes #765 Fixes #325
What is this PR about? / Why do we need it?
According to how external tools are executing the hooks, there can be a possibility that the CSIDriver gets deleted but never created. This PR adds a flag, so that the CSIDriver can be added without using helm hooks. This has the benefit that the Csidriver doesn't gets constantly recreated on each update of the chart (which doesn't make scene, imho)
Adds a flag useHelmHooksForCSIDriver to Values, which can be used to disable usage of hooks.
Currently, does not change the default behaviour to not impact existing users.
What testing is done?
Verified that the sources does not show up as deleted
Welcome @woehrl01!
It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @woehrl01. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: woehrl01 Once this PR has been reviewed and has the lgtm label, please assign jqmichael for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
We're affected by this issue as well, thank you @woehrl01 for making a PR. @justinsb @mskanth972 is there any chance that one of you can review this soon !?
Hi @mskanth972 @jqmichael Please, Could you review/approve the PR? Thank you in advance
Hi @mskanth972 @jqmichael Please, Could you review/approve the PR? Thank you in advance
ping
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale