Remove non-standard label "app" in the Helm Chart

[thetric]

/kind bug

What happened? The Helm chart is deployed with the resources labelled with app instead of the Kubernetes recommended label app.kubernetes.io/name.

What you expected to happen?

The Helm chart makes use of the recommended label.

How to reproduce it (as minimally and precisely as possible)?

Deploy it.

Anything else we need to know?:

This may possibly be a breaking change as it might require a re-installation of the Helm chart because the selector matchLabels will change.

Same issue in the AWS EBS CSI driver: https://github.com/kubernetes-csi/external-snapshotter/issues/843

Environment

• Kubernetes version (use kubectl version): 1.27
• Driver version: 2.4.5

Please also attach debug logs to help us better diagnose

n/a

• Instructions to gather debug logs can be found here

[Ashley-wenyizha]

Hi @thetric

Thanks for bringing this to us, although currently efs-csi-driver is already using app.kubernetes.io

https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/master/charts/aws-efs-csi-driver/templates/_helpers.tpl#L38

kubectl describe pod efs-csi-controller-fdd6d9d4b-slnn2 -n kube-system

Name:                 efs-csi-controller-fdd6d9d4b-slnn2
Namespace:            kube-system
Node:                 <none>
Labels:               app=efs-csi-controller
                      app.kubernetes.io/instance=aws-efs-csi-driver
                      app.kubernetes.io/name=aws-efs-csi-driver

[thetric]

Hi @Ashley-wenyizha, I would like to remove the "app"

[Kavinraja-G]

@Ashley-wenyizha Do we need to remove the label app=efs-csi-controller ? I hope that's being used by the selectors. Let me know if it's not needed, I can work on it. Thanks!

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.