aws-ebs-csi-driver icon indicating copy to clipboard operation
aws-ebs-csi-driver copied to clipboard

Add missing instances to instance store volumes table

Open ConnorJC3 opened this issue 2 years ago • 7 comments

Is this a bug fix or adding new feature?

Bug fix

What is this PR about? / Why do we need it?

Adds missing instance store instances to the table ~~Also documents command to generate this table~~ Also adds a script to generate this table

What testing is done?

Confirmed manually against table on AWS docs, as well as previous list to ensure no types were removed/changed

ConnorJC3 avatar Mar 14 '24 16:03 ConnorJC3

Code Coverage Diff

This PR does not change the code coverage

github-actions[bot] avatar Mar 14 '24 16:03 github-actions[bot]

/retest

torredil avatar Mar 14 '24 16:03 torredil

/retest

AndrewSirenko avatar Mar 14 '24 17:03 AndrewSirenko

/retest

torredil avatar Mar 14 '24 18:03 torredil

/retest

AndrewSirenko avatar Mar 14 '24 20:03 AndrewSirenko

/retest

AndrewSirenko avatar Mar 14 '24 22:03 AndrewSirenko

/retest aws-ebs-csi-driver-verify

AndrewSirenko avatar Mar 15 '24 02:03 AndrewSirenko

@AndrewSirenko: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

  • /test pull-aws-ebs-csi-driver-e2e-multi-az
  • /test pull-aws-ebs-csi-driver-e2e-single-az
  • /test pull-aws-ebs-csi-driver-external-test
  • /test pull-aws-ebs-csi-driver-external-test-eks
  • /test pull-aws-ebs-csi-driver-test-e2e-external-eks-windows
  • /test pull-aws-ebs-csi-driver-test-helm-chart
  • /test pull-aws-ebs-csi-driver-unit
  • /test pull-aws-ebs-csi-driver-verify

The following commands are available to trigger optional jobs:

  • /test pull-aws-ebs-csi-driver-external-test-arm64

Use /test all to run all jobs.

In response to this:

/retest aws-ebs-csi-driver-verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 15 '24 02:03 k8s-ci-robot

/retest pull-aws-ebs-csi-driver-verify

AndrewSirenko avatar Mar 15 '24 02:03 AndrewSirenko

@AndrewSirenko: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

  • /test pull-aws-ebs-csi-driver-e2e-multi-az
  • /test pull-aws-ebs-csi-driver-e2e-single-az
  • /test pull-aws-ebs-csi-driver-external-test
  • /test pull-aws-ebs-csi-driver-external-test-eks
  • /test pull-aws-ebs-csi-driver-test-e2e-external-eks-windows
  • /test pull-aws-ebs-csi-driver-test-helm-chart
  • /test pull-aws-ebs-csi-driver-unit
  • /test pull-aws-ebs-csi-driver-verify

The following commands are available to trigger optional jobs:

  • /test pull-aws-ebs-csi-driver-external-test-arm64

Use /test all to run all jobs.

In response to this:

/retest pull-aws-ebs-csi-driver-verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 15 '24 02:03 k8s-ci-robot

/test pull-aws-ebs-csi-driver-verify

AndrewSirenko avatar Mar 15 '24 12:03 AndrewSirenko

/approve

AndrewSirenko avatar Mar 15 '24 13:03 AndrewSirenko

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrewSirenko, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [AndrewSirenko,torredil]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 15 '24 15:03 k8s-ci-robot