aws-ebs-csi-driver
aws-ebs-csi-driver copied to clipboard
kubernetes-sigs
Allow controller to use metadata service to fetch default AZ when not specified
Is this a bug fix or adding new feature?
New feature (specify default AZ behaviour) along with some bugfixes and clarified log messages
What is this PR about? / Why do we need it?
If zone is unspecified in VolumeOptions, the default behaviour chooses a random availability zone. In practice, it is always the first availability zone listed (almost always(?) <region>a). This PR allows the controller operator to specify a flag which allows the default availability zone to be retrieved from the metadata service (as the region is).
What testing is done?
Unit testing and some end-to-end testing in a staging environment on AWS.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: hntrmrrs / name: Hunter Morris (f1c68d8e957bf1de70a47099ed133bfb229667d1, 6c159ecb1b71eeebac66659c981578bef1764ce3, cf6fa4f5e33f18deb14aa1bb0b6ce5c5cec41420, 39c326c9f680e0ebc80133ea28fd35631f4bbaf3, 22fceb7fbae18a12d0d051cd462ce040072463ec)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
- If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
- If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
- Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Welcome @hntrmrrs!
It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @hntrmrrs. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: hntrmrrs
To complete the pull request process, please assign gnufied after the PR has been reviewed.
You can assign the PR to them by writing /assign @gnufied in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
- :x: The commit (b08e59d4af2b60f684ea66edefeba7a22cf6e82c ,12c3d6a48bffbdde0adf37fa37750764cc687ecd ,480a94e30e14c2571c49726a6d5362629db71e00 ,1f2555193d4240b4732b4d383e327b76553c7a9c ,fbff321d785e82085978f97eda70a2b7787c290e ,151293e6b2cb4c4e980faa8adc6f4d17f95a30b8) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.
- :x: The commit (b08e59d4af2b60f684ea66edefeba7a22cf6e82c ,12c3d6a48bffbdde0adf37fa37750764cc687ecd ,480a94e30e14c2571c49726a6d5362629db71e00 ,1f2555193d4240b4732b4d383e327b76553c7a9c ,fbff321d785e82085978f97eda70a2b7787c290e ,151293e6b2cb4c4e980faa8adc6f4d17f95a30b8) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.
- :x: The commit (b08e59d4af2b60f684ea66edefeba7a22cf6e82c ,cb89046aa82846c3f8ee3e1439727c65fe4db147 ,d4f605227e5bbccdd50f243e6fc126ddcfbc6e3e ,f8c18d38955e1e90f328c47b8e23592519ea149d ,d6b06392331740baf95b1ab3cf99c78d809d1079) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.
The committers are authorized under a signed CLA.
- :white_check_mark: Hunter Morris (f1c68d8e957bf1de70a47099ed133bfb229667d1, 6c159ecb1b71eeebac66659c981578bef1764ce3, cf6fa4f5e33f18deb14aa1bb0b6ce5c5cec41420, 39c326c9f680e0ebc80133ea28fd35631f4bbaf3, 22fceb7fbae18a12d0d051cd462ce040072463ec)
I'm having some trouble with the new LFX platform for the CLA, but hopefully it will get resolved quickly as I've signed the agreement on behalf of my organisation.
@hntrmrrs: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle stale - Mark this issue or PR as rotten with
/lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Reopen this PR with
/reopen - Mark this PR as fresh with
/remove-lifecycle rotten - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
@k8s-triage-robot: Closed this PR.
In response to this:
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied- After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied- After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closedYou can:
- Reopen this PR with
/reopen- Mark this PR as fresh with
/remove-lifecycle rotten- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.