apiserver-network-proxy icon indicating copy to clipboard operation
apiserver-network-proxy copied to clipboard

serverCount value has no meaning in the test functions

Open ipochi opened this issue 2 years ago • 2 comments
trafficstars

I'm not sure if my understanding is correct or not but the the number of proxy servers created should reflect serverCount value.

https://github.com/kubernetes-sigs/apiserver-network-proxy/blob/fd446dc21dcca7b0674315a60ade29d642175c33/tests/proxy_test.go#L868

Similarly not sure why serverCount would be 0 in the below function ?

func runHTTPConnProxyServer() (proxy, func(), error) {
	ctx := context.Background()
	var proxy proxy
	s := server.NewProxyServer(uuid.New().String(), []server.ProxyStrategy{server.ProxyStrategyDefault}, 0, &server.AgentTokenAuthenticationOptions{})

ipochi avatar Jun 01 '23 15:06 ipochi