Flaky Test: TestDialAfterTunnelCancelled (race condition)

[tallclair]

trafficstars

Observed in https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_apiserver-network-proxy/380/pull-apiserver-network-proxy-test/1557157130442641408

I0810 00:10:08.174060    3793 client.go:134] "stream read failure"
I0810 00:10:09.177060    3793 client.go:134] "stream read failure"
I0810 00:10:09.180209    3793 client.go:134] "stream read failure"
E0810 00:10:14.184675    3793 client.go:134] "stream read failure" err="timeout recv"
E0810 00:10:19.195303    3793 client.go:134] "stream read failure" err="Recv on cancelled stream"
==================
WARNING: DATA RACE
Write at 0x00c000118610 by goroutine 37:
  runtime.closechan()
      /usr/local/go/src/runtime/chan.go:355 +0x0
  sigs.k8s.io/apiserver-network-proxy/konnectivity-client/pkg/client.(*fakeStream).Close()
      /home/prow/go/src/sigs.k8s.io/apiserver-network-proxy/konnectivity-client/pkg/client/client_test.go:369 +0x44
  sigs.k8s.io/apiserver-network-proxy/konnectivity-client/pkg/client.TestDialAfterTunnelCancelled·dwrap·31()
      /home/prow/go/src/sigs.k8s.io/apiserver-network-proxy/konnectivity-client/pkg/client/client_test.go:289 +0x39
  sigs.k8s.io/apiserver-network-proxy/konnectivity-client/pkg/client.TestDialAfterTunnelCancelled()
      /home/prow/go/src/sigs.k8s.io/apiserver-network-proxy/konnectivity-client/pkg/client/client_test.go:308 +0x976
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1259 +0x22f
  testing.(*T).Run·dwrap·21()
      /usr/local/go/src/testing/testing.go:1306 +0x47
Previous read at 0x00c000118610 by goroutine 39:
  runtime.chansend()
      /usr/local/go/src/runtime/chan.go:158 +0x0
  sigs.k8s.io/apiserver-network-proxy/konnectivity-client/pkg/client.(*fakeStream).Send()
      /home/prow/go/src/sigs.k8s.io/apiserver-network-proxy/konnectivity-client/pkg/client/client_test.go:351 +0x2a4
  sigs.k8s.io/apiserver-network-proxy/konnectivity-client/pkg/client.(*proxyServer).serve()
      /home/prow/go/src/sigs.k8s.io/apiserver-network-proxy/konnectivity-client/pkg/client/client_test.go:409 +0x148
  sigs.k8s.io/apiserver-network-proxy/konnectivity-client/pkg/client.TestDialAfterTunnelCancelled·dwrap·34()
      /home/prow/go/src/sigs.k8s.io/apiserver-network-proxy/konnectivity-client/pkg/client/client_test.go:299 +0x39
Goroutine 37 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:1306 +0x726
  testing.runTests.func1()
      /usr/local/go/src/testing/testing.go:1598 +0x99
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1259 +0x22f
  testing.runTests()
      /usr/local/go/src/testing/testing.go:1596 +0x7ca
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:1504 +0x9d1
  main.main()
      _testmain.go:57 +0x22b
Goroutine 39 (finished) created at:
  sigs.k8s.io/apiserver-network-proxy/konnectivity-client/pkg/client.TestDialAfterTunnelCancelled()
      /home/prow/go/src/sigs.k8s.io/apiserver-network-proxy/konnectivity-client/pkg/client/client_test.go:299 +0x90a
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1259 +0x22f
  testing.(*T).Run·dwrap·21()
      /usr/local/go/src/testing/testing.go:1306 +0x47
==================
--- FAIL: TestDialAfterTunnelCancelled (1.00s)
    testing.go:1152: race detected during execution of test
FAIL
FAIL	sigs.k8s.io/apiserver-network-proxy/konnectivity-client/pkg/client	12.051s