alibaba-cloud-csi-driver
alibaba-cloud-csi-driver copied to clipboard
disable DISK_FORCE_DETACHED by default
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently we will detach disk first when we are attaching this disk to another node. This is very dangerous, and can detach the disk used by a normal pod, causing data damage.
attach_detach_controller in KCM will handle force detach if node is abnormal. So we should not try to detach disk here in any case. The relevant code should also be removed in the future.
Which issue(s) this PR fixes:
Special notes for your reviewer:
We also have this env variable set to "true" in our internal component template. Consider removing it there.
Does this PR introduce a user-facing change?
DISK_FORCE_DETACHED env variable is now deprecated and disabled by default.
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: