livenessprobe
livenessprobe copied to clipboard
Support structured logging
What type of PR is this?
/kind feature
What this PR does / why we need it:
I've updated the klog functions used within csi-lib-utils to contextual logging functions, following the guidelines below: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md
In a previous PR below, I addressed structured logging, but I realized that I only handled structured logging and did not address contextual logging. https://github.com/kubernetes-csi/livenessprobe/pull/202
Therefore, in this PR, I have addressed contextual logging.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
- Added contextual logging checks using logcheck. (You can run logcheck with
make test
ormake logcheck
)
Does this PR introduce a user-facing change?:
Added support for contextual logging.
/wg structured-logging /priority important-longterm /kind cleanup /cc @pohly (I did cc because @pohly is the only member of @kubernetes/wg-structured-logging-reviews within kubernetes-csi org.)
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md#what-to-include-in-the-pull-request
/hold
https://kubernetes.slack.com/archives/C09QZFCE5/p1715087356356999
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bells17, jsafrane
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [jsafrane]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
/hold cancel logcheck crash was fixed.