livenessprobe icon indicating copy to clipboard operation
livenessprobe copied to clipboard

Support structured logging

Open bells17 opened this issue 9 months ago • 3 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

I've updated the klog functions used within csi-lib-utils to contextual logging functions, following the guidelines below: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md

In a previous PR below, I addressed structured logging, but I realized that I only handled structured logging and did not address contextual logging. https://github.com/kubernetes-csi/livenessprobe/pull/202

Therefore, in this PR, I have addressed contextual logging.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

  • Added contextual logging checks using logcheck. (You can run logcheck with make test or make logcheck)

Does this PR introduce a user-facing change?:

Added support for contextual logging.

bells17 avatar May 03 '24 18:05 bells17

/wg structured-logging /priority important-longterm /kind cleanup /cc @pohly (I did cc because @pohly is the only member of @kubernetes/wg-structured-logging-reviews within kubernetes-csi org.)

https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md#what-to-include-in-the-pull-request

bells17 avatar May 03 '24 18:05 bells17

/hold

https://kubernetes.slack.com/archives/C09QZFCE5/p1715087356356999

bells17 avatar May 07 '24 15:05 bells17

/lgtm /approve

jsafrane avatar May 13 '24 15:05 jsafrane

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bells17, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 13 '24 15:05 k8s-ci-robot

/hold cancel logcheck crash was fixed.

jsafrane avatar May 14 '24 08:05 jsafrane