external-health-monitor icon indicating copy to clipboard operation
external-health-monitor copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-csi

Only watch Pods and Nodes when Node Watcher is enabled

Open xing-yang opened this issue 4 years ago • 6 comments
trafficstars

In the external-health-monitor-controller, we always watch all PVCs, Pods, Nodes: https://github.com/kubernetes-csi/external-health-monitor/blob/v0.3.0/cmd/csi-external-health-monitor-controller/main.go#L210

We need to watch them to support the Node Watcher functionality which is disabled by default. This has caused scalability problems. https://github.com/kubernetes-csi/external-health-monitor/blob/v0.3.0/cmd/csi-external-health-monitor-controller/main.go#L66

We should change the code to only watch Pods and Nodes when the Node Watcher component is enabled.

https://github.com/kubernetes/kubernetes/issues/102452#issuecomment-856854322

xing-yang avatar Jun 08 '21 15:06 xing-yang

It also would be useful to address the scalability issue when the Node Watcher functionality is enabled.

pohly avatar Jun 09 '21 08:06 pohly

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Sep 13 '21 01:09 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Oct 13 '21 01:10 k8s-triage-robot

/remove-lifecycle rotten

pohly avatar Oct 13 '21 06:10 pohly

/lifecycle frozen

pohly avatar Oct 13 '21 06:10 pohly

/assign

mowangdk avatar Aug 30 '24 02:08 mowangdk