kubernetes-csi
Remove simple attacher mode
Before we had skip attach feature, drivers were required to run external attacher, which has a simple mode to always set attached without calling the driver.
Now that the skip attach feature is GA, there is no need to run the sidecar anymore, so this logic can be removed.
Next major version bump would probably be a good time to do this
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale
/lifecycle frozen
This needs to wait until https://github.com/kubernetes/kubernetes/issues/89173 is fixed
@humblec I remember you did some crazy stuff with your CSI drivers that don't really support ControllerPublish. Do you actually implement a dummy ControllerPublish in your driver and run a real external-attacher or you just run the external-attacher in the dummy mode?
@humblec I remember you did some crazy stuff with your CSI drivers that don't really support ControllerPublish.
@jsafrane unfortunately true that we did something which does not really fall into the CSI expectation. :(
Do you actually implement a dummy ControllerPublish in your driver and run a real external-attacher or you just run the external-attacher in the dummy mode?
latter, ie we run external-attacher in the dummy mode. The RPC is declared as unimplemented.
@humblec would it be possible for you to write a dummy ControllerPublish, so we can remove the dummy attacher mode?
@humblec would it be possible for you to write a dummy ControllerPublish, so we can remove the dummy attacher mode?
Sure @jsafrane , let me try this. I am wondering are there any other CSI drivers which run the attacher in dummy attacher mode.
@humble I can still see that the Ceph CSI drivers need the dummy attacher. Is there any plan to continue with the effort?
@msau42 if we take Ceph CSI as an example of a CSI driver that still needs the dummy attacher, does it make sense to remove it from the external-attacher? We don't know how many CSI drivers are out there that need it and it's quite small amount of code that has just worked for years.
There was a recent slack discussion where it looks like there is still a use case for the dummy attacher in order to enforce RWO. You could potentially argue that this should be something that should be enforced by the scheduler but until that happens I agree we should keep this around.
@msau42: Closing this issue.
In response to this:
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
