docs icon indicating copy to clipboard operation
docs copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-csi

update PVC annotations secret supported in external-provisioner

Open hoyho opened this issue 10 months ago • 7 comments

As mentioned in https://github.com/kubernetes-csi/external-provisioner/issues/1148, external-provisioner didn't recognize per per volume secret tokens that reference to PVCs. This was fixed is master branch of external-provisioner. CSI document should be updated to advertise this change to users. However, external-provisioner v4.0.2 hasn't published yet. This PR should wait until the new version is published.

hoyho avatar Apr 26 '24 07:04 hoyho

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 26 '24 07:04 k8s-ci-robot

/lgtm /approve

jsafrane avatar May 22 '24 08:05 jsafrane

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hoyho, jsafrane Once this PR has been reviewed and has the lgtm label, please assign saad-ali for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 22 '24 08:05 k8s-ci-robot

/assign @xing-yang for approval

jsafrane avatar May 23 '24 12:05 jsafrane

As v5.0.0 had released https://github.com/kubernetes-csi/external-provisioner/blob/v5.0.0/CHANGELOG/CHANGELOG-5.0.md . I think this PR is ok to merge now. @xing-yang

hoyho avatar Jun 12 '24 07:06 hoyho

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Sep 10 '24 07:09 k8s-triage-robot

/remove-lifecycle stale

hoyho avatar Sep 12 '24 02:09 hoyho