csi-test icon indicating copy to clipboard operation
csi-test copied to clipboard

Prow update master

Open TerryHowe opened this issue 1 year ago • 2 comments

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Update release-tools according to https://github.com/kubernetes-csi/csi-release-tools/issues/7

Which issue(s) this PR fixes: Related https://github.com/kubernetes-csi/csi-release-tools/pull/259

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

TerryHowe avatar Oct 22 '24 19:10 TerryHowe

Hi @TerryHowe. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Oct 22 '24 19:10 k8s-ci-robot

Can I get an /ok-to-test ?

TerryHowe avatar Oct 29 '24 20:10 TerryHowe

Once the tests run, I'll know if I neded the go.mod change like I was attempting in https://github.com/kubernetes-csi/csi-test/pull/560

The only other PR that might be related is https://github.com/kubernetes-csi/csi-driver-host-path/pull/570

TerryHowe avatar Nov 12 '24 16:11 TerryHowe

/ok-to-test

jsafrane avatar Dec 03 '24 11:12 jsafrane

I think the new release-tools bring new go (1.22.5) and you need to go mod tidy && go mod vendor with that go version for the PR to succeed.

jsafrane avatar Dec 03 '24 12:12 jsafrane

I addition, can you please use the current master of release-tools? We have go 1.23.1 there already.

jsafrane avatar Dec 03 '24 12:12 jsafrane

go mod tidy && go mod vendor

Done

TerryHowe avatar Dec 06 '24 12:12 TerryHowe

/lgtm /approve

jsafrane avatar Dec 09 '24 09:12 jsafrane

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, TerryHowe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Dec 09 '24 09:12 k8s-ci-robot