Add ControllerModifyVolume RPC sanity tests

[AndrewSirenko]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change /kind bug /kind cleanup /kind design /kind documentation /kind failing-test

/kind feature

/kind flake

What this PR does / why we need it: Adds sanity tests for the ControllerModifyVolume RPC such that VolumeAttributesClass ModifyVolume enhancement KEP-3751 can be promoted to Beta

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Active Questions:

1. Do we want to turn these tests on for csi-driver-host-path via /hack/e2e.sh in this PR? Or wait for the feature to officially enter Beta?
2. Are we open to the ExpectErrorCode refactor? And shall I make a separate cleanup PR?
3. Should we enforce empty MutableParameters list as InvalidArgument Err? KEP says don't enforce because field OPTIONAL, csi-spec has no mention, k/k type says required, hostpath-driver does enforce with InvalidArgument on empty.
4. Should we skip tests if no testvolumemutableparameters yaml file passed in?
5. How to enforce no conflicts between SC and VAC if both are opaque? Loop through parameter lists for duplicated keys? Or leave out test for now.

Does this PR introduce a user-facing change?:

Add csi-sanity tests for ControllerModifyVolume RPC

[k8s-ci-robot]

Welcome @AndrewSirenko!

It looks like this is your first PR to kubernetes-csi/csi-test 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-test has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[k8s-ci-robot]

Hi @AndrewSirenko. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mauriciopoppe]

/uncc

[xing-yang]

/ok-to-test

[xing-yang]

Can you squash the commits?

[xing-yang]

/lgtm /approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrewSirenko, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [xing-yang]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment