csi-test icon indicating copy to clipboard operation
csi-test copied to clipboard

use git describe --tags for version

Open huww98 opened this issue 1 year ago • 3 comments

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change /kind bug

/kind cleanup

/kind design /kind documentation /kind failing-test /kind feature /kind flake

What this PR does / why we need it:

For example, when checking out this PR, current git describe shows: v1.1.0-693-gcf1f118 git describe --tags shows: v5.2.0-7-gcf1f118

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

huww98 avatar Apr 03 '24 03:04 huww98

Hi @huww98. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 03 '24 03:04 k8s-ci-robot

/ok-to-test

xing-yang avatar Apr 08 '24 16:04 xing-yang

/lgtm /approve

xing-yang avatar May 29 '24 13:05 xing-yang

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huww98, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 29 '24 13:05 k8s-ci-robot