csi-driver-nfs icon indicating copy to clipboard operation
csi-driver-nfs copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-csi

Updating chart content without incrementing the version

Open woehrl01 opened this issue 1 year ago • 8 comments

What happened:

The following commit updated the chart content without incrementing the version tag. I'm not sure if this is intended but this leads to updating all helm deployments to that content without noticing directly.

https://github.com/kubernetes-csi/csi-driver-nfs/commit/30c0f8fb104de1db7c165303ae271ab4ea2e0120

Bildschirmfoto 2024-07-18 um 12 01 09

What you expected to happen:

If a new version gets released, the version should be incremented. Older versions should not be changed.

How to reproduce it:

Anything else we need to know?:

Environment:

  • CSI Driver version:
  • Kubernetes version (use kubectl version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

woehrl01 avatar Jul 18 '24 10:07 woehrl01

@woehrl01 that's intended, mainly for fixing the CVEs in sidecar containers.

andyzhangx avatar Jul 18 '24 11:07 andyzhangx

@andyzhangx I see, but shouldn't a change, even for CVEs, result in a version increment?

woehrl01 avatar Jul 18 '24 12:07 woehrl01

I'm unable to use the newer chart version since this images doesn't exist:

$ docker pull registry.k8s.io/sig-storage/nfsplugin:v4.8.0
Error response from daemon: manifest for registry.k8s.io/sig-storage/nfsplugin:v4.8.0 not found: manifest unknown: Failed to fetch "v4.8.0"

Failed to pull image "registry.k8s.io/sig-storage/nfsplugin:v4.8.0": rpc error: code = NotFound desc = failed to pull and unpack image "registry.k8s.io/sig-storage/nfsplugin:v4.8.0": failed to resolve reference "registry.k8s.io/sig-storage/nfsplugin:v4.8.0": registry.k8s.io/sig-storage/nfsplugin:v4.8.0: not found

The version is pinned here: https://github.com/kubernetes-csi/csi-driver-nfs/blob/a3ffafe2ea9383d45f212b42db1a35da7963b197/charts/v4.8.0/csi-driver-nfs/values.yaml#L5-L6

Skaronator avatar Jul 18 '24 14:07 Skaronator

@Skaronator see #589

woehrl01 avatar Jul 18 '24 14:07 woehrl01

Ah okay thanks. Only looked at recent issues.

I'm just gonna add a 4 hour delay to renovate for this helm chart :)

Skaronator avatar Jul 18 '24 14:07 Skaronator

@andyzhangx I see, but shouldn't a change, even for CVEs, result in a version increment?

100% agreed. Pretty much every other chart I've ever seen increments it's patch version for image patching. It's very important in any kind of environment that has strict change control not to introduce spontaneous changes without a change in config (kind of the whole point of infrastructure-as-code).

gclawes avatar Jul 19 '24 00:07 gclawes

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Oct 17 '24 01:10 k8s-triage-robot

/remove-lifecycle stale

Skaronator avatar Oct 17 '24 07:10 Skaronator

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 15 '25 08:01 k8s-triage-robot

/remove-lifecycle stale

Skaronator avatar Jan 15 '25 10:01 Skaronator

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 15 '25 10:04 k8s-triage-robot

/remove-lifecycle stale

Skaronator avatar Apr 15 '25 10:04 Skaronator

already fixed by v4.11.0:

https://github.com/kubernetes-csi/csi-driver-nfs/blob/d67fe060170a60a70124642a0ef8181cbeb8ecac/charts/v4.11.0/csi-driver-nfs/Chart.yaml#L1-L5

andyzhangx avatar May 12 '25 03:05 andyzhangx