csi-driver-iscsi icon indicating copy to clipboard operation
csi-driver-iscsi copied to clipboard

Ability to put targetd parameters in StorageClass like in old targed iscsi-provisioner

Open lukasg-d opened this issue 1 year ago • 5 comments

Is your feature request related to a problem?/Why is this needed

At this moment, according to examples, targetd parameters can be only placed in PV, to reduce burden we'd like to have it in one place

Describe the solution you'd like in detail

Ability to have iscsi connection details in one place, ie. StorageClass in similar way like old targetd iscsi-provisioner had:

parameters:
  chapAuthDiscovery: 'false'
  chapAuthSession: 'false'
  fsType: ext4
  initiators: >-
    iqn.x.y.z:node1,iqn.x.y.z:node2,iqn.x.y.z:node3,iqn.x.y.z:node4
  iqn: iqn.x.y.z:targetd
  targetPortal: 192.x.y.z:3260
  volumeGroup: lvm-iscsi

Describe alternatives you've considered

Old targetd iscsi-provisioner

Additional context

lukasg-d avatar Dec 04 '23 09:12 lukasg-d

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Mar 03 '24 14:03 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Apr 02 '24 14:04 k8s-triage-robot

Hi @lukasg-d, did you manage to get a storage class working similar to the one with the iscsi-provisioner? It's unclear whether the provisioner of this csi driver would accept the right storage class parameters.

jmrr avatar Apr 18 '24 00:04 jmrr

Hi, at the time of writing previous comment I couldn't make it working, so I assume that csi driver is not accepting right storage class parameters.

lukasg-d avatar Apr 18 '24 07:04 lukasg-d

that's because this driver does not implement CreateVolume api, storage class won't work: https://github.com/kubernetes-csi/csi-driver-iscsi/blob/554efb1ffe6723c96c912c09000d3b7867c6f8a3/pkg/iscsi/controllerserver.go#L32

andyzhangx avatar Apr 18 '24 11:04 andyzhangx

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar May 18 '24 12:05 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 18 '24 12:05 k8s-ci-robot