csi-driver-host-path
csi-driver-host-path copied to clipboard
Create Helm Chart from Static Manifests
What type of PR is this? /kind feature
What this PR does / why we need it:
This PR convert our static deployment manifests from deploy/kubernetes-latest/* into Helm Charts under charts/*, by running a convert script under deploy/util/chart-releaser.sh.
Moreover, it handle the chart release with branch gh-pages, by integrate with https://github.com/helm/chart-releaser-action.
The sample helm repo could find from https://alvistack.github.io/kubernetes-csi-csi-driver-host-path/index.yaml, by:
helm repo add csi-driver-host-path https://alvistack.github.io/kubernetes-csi-csi-driver-host-path/
helm repo update
helm search repo csi-driver-host-path
Before each stable tag release, maintainers only required to:
- Run the
./deploy/kubernetes-latest/chart-releaser.shand update templates undercharts/*/templates/* - Double confirm
charts/*/values.ymlwith correct values, e.g. image tags git add --all --force charts/* && git commit
Create Helm Chart from Static Manifests
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: hswong3i Once this PR has been reviewed and has the lgtm label, please assign msau42 for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @hswong3i. Thanks for your PR.
I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
/remove-lifecycle stale
Thanks for your contribution.
This repo is mainly used for kubeneretes to test storage e2e tests. I'm not sure how much benefit we'll get from this PR because it might introduce extra maintenance burden.
I have no objection to this PR. Let's hear from others.
/cc @xing-yang @msau42 /ok-to-test
This repo is mainly used for kubeneretes to test storage e2e tests. I'm not sure how much benefit we'll get from this PR because it might introduce extra maintenance burden.
This PR already introduce a simple wrapper script for converting existing static manifests into helm.
Before each stable tag release, maintainers only required to:
- Run the ./deploy/kubernetes-latest/chart-releaser.sh and update templates under charts//templates/
- Double confirm charts/*/values.yml with correct values, e.g. image tags
- git add --all --force charts/* && git commit