csi-driver-host-path icon indicating copy to clipboard operation
csi-driver-host-path copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-csi

Implement CSI SnapshotMetadata service

Open PrasadG193 opened this issue 1 year ago • 4 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR implements SnapshotMetadata service from the CSI specs. This service in combination with external-snapshot-metadata will be used to compare and query changed block metadata between two snapshots. Right now, the service will be disabled by default till external-snapshot-metadata alpha is release.

The changes in deploy script to add external-snapshot-metadata sidecar will be added after alpha release.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

PrasadG193 avatar Oct 15 '24 12:10 PrasadG193

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

k8s-ci-robot avatar Oct 15 '24 12:10 k8s-ci-robot

/assign /assign @bswartz

xing-yang avatar Oct 25 '24 02:10 xing-yang

This is a new feature. Please add a release note. Can you add a note in the PR description that this is a sample implementation, and not for production use.

xing-yang avatar Oct 31 '24 15:10 xing-yang

@carlbraganza @xing-yang I've addressed the feedback. PTAL

PrasadG193 avatar Nov 07 '24 14:11 PrasadG193

@PrasadG193 LGTM! Need approval from @xing-yang or @bswartz

carlbraganza avatar Nov 14 '24 18:11 carlbraganza

Can you add your testing steps?

xing-yang avatar Dec 02 '24 17:12 xing-yang

Can you add your testing steps?

hey @xing-yang ,

@PrasadG193 is on vacation and will be back thursday.

He had developed a client to test the new RPCs https://github.com/PrasadG193/external-snapshot-metadata-client which has been adopted as a tool in this pr https://github.com/kubernetes-csi/external-snapshot-metadata/pull/64

We are creating a gh action that adds simple e2e https://github.com/kubernetes-csi/external-snapshot-metadata/issues/67

Add a github action that:
- checkout repository
- sets up minikube
- builds latest sidecar image
- deploys csi-driver-hostpath driver resources
- runs simple e2e tests to create pvc, pod and snapshots and to write data.
- run client to verify working of both RPCs.

Sample run https://github.com/Rakshith-R/external-snapshot-metadata/actions/runs/12163453092/job/33922692908 (with the fix @iPraveenParihar has suggested above)

Rakshith-R avatar Dec 04 '24 16:12 Rakshith-R

@xing-yang I have documented complete test plan along with steps to deploy csi driver with external-snapshot-metadata here - https://gist.github.com/PrasadG193/1fab082f03bbdb7db25a41ed17b7e7c1

PrasadG193 avatar Dec 09 '24 12:12 PrasadG193

LGTM! @PrasadG193

iPraveenParihar avatar Dec 10 '24 12:12 iPraveenParihar

/approve

xing-yang avatar Dec 18 '24 17:12 xing-yang

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bswartz, PrasadG193, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Dec 18 '24 17:12 k8s-ci-robot