kubernetes-csi
bump CSI spec to next version
What type of PR is this?
Uncomment only one
/kind <>line, hit enter to put that in a new line, and remove leading whitespaces from that line:/kind api-change /kind bug
/kind cleanup
/kind design /kind documentation /kind failing-test /kind feature /kind flake
What this PR does / why we need it:
bump CSI spec to next version and fix the build failure
remove direct deps on github.com/golang/protobuf. Since it is outdated and replaced by google.golang.org/protobuf
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This uses an unreleased version of CSI spec. If we are not in hurry merging this, I'll update this PR when a new release is available.
Does this PR introduce a user-facing change?:
NONE
Welcome @huww98!
It looks like this is your first PR to kubernetes-csi/csi-driver-host-path 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-csi/csi-driver-host-path has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @huww98. Thanks for your PR.
I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
I think we do not update to unreleased CSI spec version. If you're prototyping a feature, you can send a WIP PR with the feature + CSI spec update, so others can comment or test.
The next CSI spec version will bring a breaking change, so I just raised this PR earlier to fix it, so that we can do the tests and review earlier.
/ok-to-test
I'm enabling CI in this PR to see any breakages then. /hold until the official CSI spec release
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: huww98, jsafrane
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [jsafrane]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment