kubernetes-client
Kubernetes Python Client to return "Terminating" for terminating pods
What type of PR is this? /kind bug
What this PR does / why we need it: This PR makes Kubernetes Python Client to return "Terminating" for terminating pods
Which issue(s) this PR fixes: Fixes https://github.com/kubernetes-client/python/issues/2397
Special notes for your reviewer: None
Does this PR introduce a user-facing change? None
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: None
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: p172913 Once this PR has been reviewed and has the lgtm label, please assign roycaihw for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Created new pull request for the issue #2397 . As per the request in previous pull request to rebase the commits... https://github.com/kubernetes-client/python/pull/2425
Below are valid pod phases. k8s golang client would return this set of phases, so does the this python client.
// PodPhase is a label for the condition of a pod at the current time. // +enum type PodPhase string
// These are the valid statuses of pods. const ( // PodPending means the pod has been accepted by the system, but one or more of the containers // has not been started. This includes time before being bound to a node, as well as time spent // pulling images onto the host. PodPending PodPhase = "Pending" // PodRunning means the pod has been bound to a node and all of the containers have been started. // At least one container is still running or is in the process of being restarted. PodRunning PodPhase = "Running" // PodSucceeded means that all containers in the pod have voluntarily terminated // with a container exit code of 0, and the system is not going to restart any of these containers. PodSucceeded PodPhase = "Succeeded" // PodFailed means that all containers in the pod have terminated, and at least one container has // terminated in a failure (exited with a non-zero exit code or was stopped by the system). PodFailed PodPhase = "Failed" // PodUnknown means that for some reason the state of the pod could not be obtained, typically due // to an error in communicating with the host of the pod. // Deprecated: It isn't being set since 2015 (74da3b14b0c0f658b3bb8d2def5094686d0e9095) PodUnknown PodPhase = "Unknown" )
