python icon indicating copy to clipboard operation
python copied to clipboard

CRD version properties are inadvertently removed when serializing

Open whatsacomputertho opened this issue 4 months ago • 2 comments

Summary

I am loading a V1CustomResourceDefinition, making a small modification to it, then re-serializing it, and I am seeing numerous unintended mutations / removals made to the resulting output CRD

Similar defect as:

  • https://github.com/kubernetes-client/python/issues/2435

Details

Here are the sequence of diffs for my CRD:

@@ -17,111 +16,12 @@

   group: mycr.me.com
   names:
     kind: MyCR
-    listKind: MyCRList
     plural: mycrs
     singular: mycr

...

-  ... (Removed additionalPrinterColumns)
-  ... (Removed the entire version schema)
+  - name: v1beta1
+    schema: {}

whatsacomputertho avatar Aug 14 '25 18:08 whatsacomputertho

/help

roycaihw avatar Aug 14 '25 20:08 roycaihw

@roycaihw: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 14 '25 20:08 k8s-ci-robot