kubernetes-client
Changes made in configuration.py to accept environmental variables
What type of PR is this? /kind bug
What this PR does / why we need it: This PRs will read environment variables assigned for proxy and no_proxy.
Which issue(s) this PR fixes: Fixes https://github.com/kubernetes-client/python/issues/2321
Special notes for your reviewer: Unit test is added kubernetes\base\stream\ws_client_test.py
Does this PR introduce a user-facing change? None
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: None
Please remove the "Merge branch 'kubernetes-client:master' into master" commit to make the commits clear. You may have to start from a new branch to do so.
This commit is reverted back.
I added a bash script file. This will edit configuration.py file if we create it using new opneapi generator.
@roycaihw I have been working get this upstream: https://github.com/OpenAPITools/openapi-generator/pull/21394
Edit: I ceased working on it for the time being.
@roycaihw I have been working get this upstream: OpenAPITools/openapi-generator#21394
Oh ok. Then @roycaihw I will remove statement to execute insert_proxy_config.sh from scripts/release.sh. So, that we can execute insert_proxy_config.sh only if needed instead of running always....
@roycaihw I have been working get this upstream: OpenAPITools/openapi-generator#21394
Oh ok. Then @roycaihw I will remove statement to execute insert_proxy_config.sh from scripts/release.sh. So, that we can execute insert_proxy_config.sh only if needed instead of running always....
@roycaihw What do you think...
Could you squash the commits? Otherwise LGTM. https://www.kubernetes.dev/docs/guide/github-workflow/#squash-commits
Could you squash the commits? Otherwise LGTM. https://www.kubernetes.dev/docs/guide/github-workflow/#squash-commits
@roycaihw squashed commits as per instructions.
Could you squash the commits? Otherwise LGTM. https://www.kubernetes.dev/docs/guide/github-workflow/#squash-commits
@roycaihw squashed commits as per instructions.
@roycaihw please approve my commit.
Could you squash the commits? Otherwise LGTM. https://www.kubernetes.dev/docs/guide/github-workflow/#squash-commits
@roycaihw squashed commits as per instructions.
@roycaihw please approve my commit.
@roycaihw Do i need to add anything to this...?
@roycaihw Can you please look into my PR. I squashed my commits as you mentioned. Please approve my Pull request....
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: p172913, roycaihw
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [roycaihw]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
