python icon indicating copy to clipboard operation
python copied to clipboard

Remove py from test-requirements.txt

Open jelly opened this issue 1 year ago • 6 comments

py is in maintenance mode and nothing in this project depends on it.

What type of PR is this?

Fixes #2286

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Remove py from test dependencies

jelly avatar Sep 26 '24 13:09 jelly

Welcome @jelly!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Sep 26 '24 13:09 k8s-ci-robot

please sign cla

yliaog avatar Sep 27 '24 00:09 yliaog

please sign cla

Done

jelly avatar Sep 30 '24 10:09 jelly

/lgtm /approvev

yliaog avatar Sep 30 '24 23:09 yliaog

/approve

anandfresh avatar Nov 03 '24 04:11 anandfresh

Can this be merged?

jelly avatar Nov 08 '24 12:11 jelly

/approve

yliaog avatar Nov 10 '24 02:11 yliaog

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anandfresh, jelly, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 10 '24 02:11 k8s-ci-robot