python icon indicating copy to clipboard operation
python copied to clipboard

fix: missing method invocation in kube_config_test.py

Open kavishdahekar opened this issue 1 year ago • 4 comments

What type of PR is this?

/kind bug

What this PR does / why we need it:

The test_load_kube_config_from_dict_with_temp_file_path test calls _cleanup_temp_files without invoking it _cleanup_temp_files(). This PR fixes that.

Which issue(s) this PR fixes:

Fixes n/a

Special notes for your reviewer:

n/a

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


kavishdahekar avatar Aug 27 '24 11:08 kavishdahekar

Welcome @kavishdahekar!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Aug 27 '24 11:08 k8s-ci-robot

/assign @yliaog

roycaihw avatar Aug 28 '24 19:08 roycaihw

/lgtm /approve

yliaog avatar Aug 30 '24 22:08 yliaog

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kavishdahekar, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 30 '24 22:08 k8s-ci-robot