python icon indicating copy to clipboard operation
python copied to clipboard

kubernetes 3.1.0 is failing with python 3.12

Open swaruparameshpajju opened this issue 1 year ago • 6 comments

build-kubernetes-30.1.0-2024-08-07-10-19-11-348-65896464.txt What happened (please include outputs or screenshots):

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Kubernetes version (kubectl version):
  • OS (e.g., MacOS 10.13.6):
  • Python version (python --version)
  • Python client version (pip list | grep kubernetes)

swaruparameshpajju avatar Aug 07 '24 12:08 swaruparameshpajju

Python 3.12 is not tested https://github.com/kubernetes-client/python/blob/90d4fef7aaa9f71f3f5fad0f6100b07ef48ae158/tox.ini#L2-L4

Some investigation would be needed if we want to support 3.12

roycaihw avatar Aug 14 '24 20:08 roycaihw

Hi Team, any updates on this?

heysarthak avatar Aug 23 '24 06:08 heysarthak

/help

roycaihw avatar Aug 26 '24 19:08 roycaihw

@roycaihw: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 26 '24 19:08 k8s-ci-robot

Hi @swaruparameshpajju,

I'd like to work on this issue. Could you please provide more details? Specifically, it would be helpful to know which script you executed to test this functionality.

For context, I used Python 3.12.4 along with the Python Kubernetes client version 30.1.0. I also tried the example provided in examples/deployment_create.py, and it worked successfully for me.

Bhargav-manepalli avatar Sep 02 '24 06:09 Bhargav-manepalli

@roycaihw Could this line be changed?

https://github.com/kubernetes-client/python/blob/master/setup.py#L70

From

python_requires='>=3.6',

To

python_requires='>=3.6,<3.12',

(I would submit a PR, but getting a corporate CLA just for that seems like a waste of time :).)

dmyersturnbull avatar Dec 10 '24 19:12 dmyersturnbull