python icon indicating copy to clipboard operation
python copied to clipboard

pick proxy from kube_config

Open kwibus opened this issue 7 months ago • 8 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

kubeconfig support the option proxy-url . This is option is ignored by this client. and people have trouble to configer there proxy #1967 This pull request will use that option to set kubernetes.client.load_kube_config()' to set kubernetes.client.configuration.proxy`

Which issue(s) this PR fixes:

Fixes #2183

Special notes for your reviewer:

Does this PR introduce a user-facing change?

`load_kube_config`, ` new_client_from_config_dict`, `new_client_from_config` will use `proxy-url` cluster setting to `set client..configuration.proxy`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


kwibus avatar Jan 20 '24 23:01 kwibus

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: kwibus / name: Rens (376f179ea114c6299055a9c68836a419e5de3d0d, f27bb49bf10bb77af2784d9d81efebdf72cfd143)

Welcome @kwibus!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Jan 20 '24 23:01 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kwibus Once this PR has been reviewed and has the lgtm label, please assign yliaog for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jan 20 '24 23:01 k8s-ci-robot

/assign

roycaihw avatar Feb 12 '24 17:02 roycaihw

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 12 '24 18:05 k8s-triage-robot

@roycaihw any chance we could look at this? I can lend a hand for testing it!

MadJlzz avatar May 15 '24 13:05 MadJlzz

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fabianvf, kwibus Once this PR has been reviewed and has the lgtm label, please ask for approval from roycaihw. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 15 '24 14:05 k8s-ci-robot

/lgtm

fabianvf avatar May 15 '24 14:05 fabianvf

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jun 14 '24 14:06 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Jul 14 '24 14:07 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 14 '24 14:07 k8s-ci-robot