python
python copied to clipboard
kubernetes-client
Add base_resource_lookup to ResourceList to avoid logging error
Signed-off-by: Alex Kalenyuk [email protected]
What type of PR is this?
/kind bug
What this PR does / why we need it:
As seen in https://github.com/openshift/openshift-restclient-python/issues/430 We are hitting a bunch of these logging errors:
load cache error: __init__() got an unexpected keyword argument 'base_resource_lookup'
Which seem like they could be fixed by expecting this arg.
We might be off here so would appreciate any pointers, but kept it simple at this point without adding the actual client request support.
Thanks @myakove for the help.
Which issue(s) this PR fixes:
Fixes #1857
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Welcome @akalenyu!
It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-client/python has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
/assign @fabianvf
gentle ping, feel free to let us know if we are not in the right direction
Sorry missed that, ping very much appreciated. Looks straightforward to me
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: akalenyu, fabianvf, yliaog
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~kubernetes/base/OWNERS~~ [yliaog]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Sorry missed that, ping very much appreciated. Looks straightforward to me
Thank you :pray: What would be the next step? did we need lgtm instead of approve?