python
python copied to clipboard
kubernetes-client
Instead of mock, used unittest.mock
What type of PR is this?
bug
What this PR does / why we need it:
Used unittest.mock instead of mock
Which issue(s) this PR fixes:
Fixes #1790
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
None
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
None
Welcome @harshitasao!
It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-client/python has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: harshitasao, roycaihw
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~kubernetes/base/OWNERS~~ [roycaihw]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment