minor issue with `requirements.txt`

[jearls]

There is a requirement to have setuptools installed when running setup.py; however, setuptools is not required to actually run the client, as far as I can tell. From my understanding, setuptools should not be part of requirements.txt if it's only used for building and is not needed in the distributed form.

[roycaihw]

Could you verify if the installation still works with the requirement removed? If that's the case, would you like to send a PR? Thanks!

[prescod]

Getting permission to sign the CLA is a bit of a hassle for me, but I did try to move "setuptools" from "requirements.txt" to "test-requirements.txt" and ran "pip install -e ." and everything seemed to go smoothly.

One reason to remove it is because when you use pip-tools with any project that derives from kubernetes-client, you get an error message like:

# The following packages are considered to be unsafe in a requirements file:
# setuptools

One of the vulnerability monitoring companies also has a beef with setuptools which causes a headache for vulnerability scanners at bigcos.

[xtaje]

The way the requirements files are being used has a couple other problems. They are not really supposed to be read and parsed into setup.py. Moving it into test-requirements.txt still implies a circular dependency (kubernetes package installation -> setuptools -> kubernetes package installation).

Pip usually installs setuptools IIRC, so if you're using pip, then you will already have setuptools installed, so it happens to work OK for most users regardleess.

The intended way to use those files is described here https://packaging.python.org/en/latest/discussions/install-requires-vs-requirements/

[Shivansh2407]

Hey @prescod and @roycaihw , would you suggest cleaning up the requirements file, if no one's working on this? I'll verify this and make a PR for the same, if @prescod is not working on this currently. Thanks!

[Rishit-dagli]

/assign

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.