javascript
javascript copied to clipboard
kubernetes-client
Should `erasableSyntaxOnly` be enabled
TypeScript 5.8 added a new compiler option named erasableSyntaxOnly. This option is somewhat of a collaboration with the Node core team as it disallows TypeScript syntax that Node's type stripping does not support.
There are currently 49 errors reported when enabling this option, which is why I'm opening an issue instead of a PR.
If we don't want to work toward enabling it, that's fine, and we can carry on with the status quo. If we do want to enable it, it would lead to a future where we no longer need to transpile for anything except npm publish and running the transpiled tests in the CI.
I started looking into this. Mostly the errors are due to the use of automatic member variables via readonly constructor parameters. Those are easy to fix, though they do make the code a little more verbose.
Some of them are due to the use of enums in the generated code. That's going to require upstream changes in the code generator and a regeneration of the code.
I'll send a PR with all of the local fixes sometime in the next day or two, then work on the upstream generator (unless someone else in the community gets there first)
Generator changes are here: https://github.com/OpenAPITools/openapi-generator/pull/21040
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue as fresh with
/remove-lifecycle stale - Close this issue with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue as fresh with
/remove-lifecycle rotten - Close this issue with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Reopen this issue with
/reopen - Mark this issue as fresh with
/remove-lifecycle rotten - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close not-planned
@k8s-triage-robot: Closing this issue, marking it as "Not Planned".
In response to this:
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied- After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied- After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closedYou can:
- Reopen this issue with
/reopen- Mark this issue as fresh with
/remove-lifecycle rotten- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close not-planned
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
reopening this while continuing in gen repo pr https://github.com/kubernetes-client/gen/pull/284?
merged generator PR https://github.com/OpenAPITools/openapi-generator/pull/21560
@davidgamero: Reopened this issue.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.