java icon indicating copy to clipboard operation
java copied to clipboard

Automated Generate from openapi release-1.34

Open yue9944882 opened this issue 3 months ago • 5 comments

yue9944882 avatar Nov 21 '25 03:11 yue9944882

CLA Not Signed

  • :x: - login: @k8s-publishing-bot / name: Kubernetes staging repo publishing bot . The commit (1d0cb54c2afbc570de9b354e8fae71131321c0ca, 894789533d7e2daeb65e0b3f6e88feadc11417d5, 9f8f9032119d4ce4a875e6e6075d52da9160b4a6, f39ab76567e4a8a6d8cd3fbb9a983c06d44697f6) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 21 '25 03:11 k8s-ci-robot

So I was hoping to pick up the recent changes I made to add tlsServerName support to the code generator, but I think I need to up the commit version that we use in the generator, this did pick up some fluent updates, so I think we may as well merge it, but we probably also need to re-squash it or something so tha the CLA bot is happy.

brendandburns avatar Nov 21 '25 03:11 brendandburns

just to confirm, does this PR include the tls change you are looking for? note our generation workflow is based on the latest content in this file:

https://github.com/kubernetes-client/gen/blame/master/openapi/java.sh#L52

yue9944882 avatar Nov 25 '25 20:11 yue9944882

No, we need to wait for an OpenAPI generator release which includes it and then rev the version forward.

We can still merge this though if we want looks like there are some set related fixes.

brendandburns avatar Nov 26 '25 22:11 brendandburns