java icon indicating copy to clipboard operation
java copied to clipboard

Umbrella Issue: Java8 incompatible dependencies

Open yue9944882 opened this issue 2 years ago • 7 comments

The following dependencies failed to be upgraded due to Java8 incompatibility:

  • https://github.com/kubernetes-client/java/pull/2773
  • https://github.com/kubernetes-client/java/pull/2771

yue9944882 avatar Aug 25 '23 21:08 yue9944882

@yue9944882 Perhaps we should move forward to Java11 at one of the major versions?

Alternately we could have a minor version for Java8 and a minor version for Java11 (e.g. 19.1.x == java8, 19.0.x == java11)

brendandburns avatar Aug 28 '23 15:08 brendandburns

Or do you want to jump straight to Java17?

brendandburns avatar Aug 28 '23 15:08 brendandburns

Alternately we could have a minor version for Java8 and a minor version for Java11 (e.g. 19.1.x == java8, 19.0.x == java11)

@brendandburns i'm not sure bumping major is easy to users to understand. maybe just adding a .java8 suffix will be more intuitive? 🤔

regarding the spring 17 support, i think we can skip compiling for those java8 incompatible modules in our test job if we want to bump those dependencies to java11, so java8 users can still use the java8-compatible modules anyway. See this commit in https://github.com/kubernetes-client/java/pull/2773: https://github.com/kubernetes-client/java/pull/2773/commits/14f8bc6c1659c7c509e3afc5808631b3763be193, this will only require java17 for those who wants to opt-in to spring support.

as for mockito, i don't see the necessity to bump that at this point? since that it's just a test-dependency. probably we can figure out how to support java8 in long-term when there's a more convincing dependency needs us to upgrade in the future?

yue9944882 avatar Aug 30 '23 03:08 yue9944882

Ok, sounds good to me. I figured out how to handle the logback dependency that seemed to have a similar problem, so that's another one off the list.

We can defer this until we're really stuck.

brendandburns avatar Aug 31 '23 16:08 brendandburns

Another Java11+ dependency:

https://github.com/kubernetes-client/java/pull/2782

brendandburns avatar Sep 07 '23 18:09 brendandburns

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 27 '24 21:01 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Feb 26 '24 22:02 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Mar 27 '24 23:03 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 27 '24 23:03 k8s-ci-robot