remove unused util code
- remove duplicated generic code which impled
- remove unfinished cache/informer code (still missing informer reflector ...)
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: tg123
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [tg123]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
#846
We used in our code the GenericKubernetesApi to watch kubernetes resources (namespaces scoped and global), this class was removed from nuget 9.0.x
// constructor
_genericClient = new GenericClient(_kubernetesClient, GROUP, VERSION, PLURAL);
_genericKubernetesApi = new GenericKubernetesApi(GROUP, VERSION, PLURAL, _kubernetesClient);
// later
var watcher = _genericKubernetesApi.Watch(NAMESPACE, onEvent, onError, onClosed, cancellationToken);
We are using this approach to be able to reconnect when the connection is lost (onClosed) and for the error logging. With removing of the API, I think we need to change to, the way shown in Watch Example.
But how can we deal with reconnect and error logging in that case?
thanks for reporting, will add watch as requested
@tg123 will watch be added to this PR? Or in a follow up?
@tg123 will watch be added to this PR? Or in a follow up?
lets do it in followup
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: brendandburns, tg123
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [brendandburns,tg123]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment