csharp icon indicating copy to clipboard operation
csharp copied to clipboard

[Code style] Force code writing style verification during pull request checks

Open m3nax opened this issue 3 years ago • 6 comments

Force code writing style verification during pull request checks.

Objective:

  • increase the uniformity of the writing style of the code

m3nax avatar Sep 14 '22 20:09 m3nax

kubernetes-client.ruleset

tg123 avatar Sep 14 '22 20:09 tg123

Can we make more restrictive rule? Making your code smoother and more consistent makes editing easier and it makes contributing easier....

m3nax avatar Sep 14 '22 20:09 m3nax

Witch Action check code style?

m3nax avatar Sep 14 '22 20:09 m3nax

@m3nax we used to have it, but it looks like @tg123 may have accidentally removed it in https://github.com/kubernetes-client/csharp/commit/250a45741e04662a408af508ec87dfb66eed1bdb

@tg123 was this on purpose? (and my mistake for missing it at the time when I reviewed it...)

brendandburns avatar Sep 20 '22 15:09 brendandburns

not a mistake

the dotnet fmt conflicts with stylecop check

cannot pass them together, so I disable the dotnet fmt

tg123 avatar Sep 20 '22 18:09 tg123

ruleset is deprecated: https://learn.microsoft.com/en-us/visualstudio/code-quality/use-roslyn-analyzers?view=vs-2019#convert-an-existing-ruleset-file-to-editorconfig-file

Can i covert it in a .editorconfig?

m3nax avatar Sep 20 '22 20:09 m3nax

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 19 '22 20:12 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jan 18 '23 21:01 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Feb 17 '23 22:02 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 17 '23 22:02 k8s-ci-robot