machine-controller Add cluster labels to kubevirt vm

What this PR does / why we need it: For https://github.com/kubermatic/kubermatic/issues/10923 we need to add cluster labels to KubeVirt VMs on creation.

Does this PR introduce a user-facing change? Then add your Release Note here:

Add cluster labels to KubeVirt VM

Documentation:

NONE

Nov 02 '22 06:11 dermorz

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dermorz Once this PR has been reviewed and has the lgtm label, please assign ahmedwaleedmalik for approval by writing /assign @ahmedwaleedmalik in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS
pkg/cloudprovider/provider/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Nov 02 '22 06:11 kubermatic-bot

/hold I would need to check something in kubevirt ccm.

Nov 07 '22 13:11 hdurand0710

@dermorz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-machine-controller-e2e-vsphere	46dfb21b530b746923c95a9740a3c2ede82ac51f	link	true	`/test pull-machine-controller-e2e-vsphere`

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Nov 08 '22 12:11 kubermatic-bot

Can you please also update examples/kubevirt-machinedeployment.yaml with the new parameter ?

Nov 14 '22 09:11 hdurand0710

/lgtm /approve

Nov 14 '22 10:11 hdurand0710

LGTM label has been added.

Git tree hash: df8c9b82fcf10f94e073b210444bf7c411a0ba06

Nov 14 '22 10:11 kubermatic-bot

Can you please also update examples/kubevirt-machinedeployment.yaml with the new parameter ?

Yes, and also docs/kubevirt.md.

Nov 14 '22 11:11 dermorz

/retest

Nov 14 '22 13:11 dermorz

/retest

Nov 14 '22 15:11 dermorz

/retest

Nov 15 '22 06:11 dermorz

/retest

Nov 16 '22 14:11 dermorz

/retest

Nov 21 '22 06:11 dermorz

/unhold KKP is merged

Nov 21 '22 07:11 hdurand0710

/retest

Nov 21 '22 08:11 dermorz

/lgtm /approve

Nov 21 '22 09:11 hdurand0710

LGTM label has been added.

Git tree hash: 3d2c8f5aa0307e7fc4ace8d17a79eab92c2712b3

Nov 21 '22 09:11 kubermatic-bot

/retest

Nov 22 '22 07:11 dermorz

/assign @ahmedwaleedmalik

Nov 22 '22 14:11 dermorz

/lgtm /approve

Nov 23 '22 07:11 hdurand0710

LGTM label has been added.

Git tree hash: bda20dc3a16828a3698542d9e2dcf754dfdfd6b0

Nov 23 '22 07:11 kubermatic-bot

/retest

Nov 23 '22 19:11 ahmedwaleedmalik

/approve

Nov 23 '22 19:11 ahmedwaleedmalik

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, dermorz, hdurand0710

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ahmedwaleedmalik,hdurand0710]
~~pkg/cloudprovider/provider/OWNERS~~ [ahmedwaleedmalik]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Nov 23 '22 19:11 kubermatic-bot

/retest This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Nov 23 '22 21:11 kubermatic-triage-bot

machine-controller machine-controller copied to clipboard

Add cluster labels to kubevirt vm

machine-controller
machine-controller copied to clipboard