machine-controller
machine-controller copied to clipboard
kubermatic
add http source for kubevirt VM Disk Image
What this PR does / why we need it:
This PR introduces PrimarDiskImageSource for the KubeVirt provider. The source can be HTTP or PVC-Clone.
If the source is HTTP with preAllocatedDataVolume as false, the VM disk-image will be downloaded from the HTTP source.
If the source is HTTP with preAllocatedDataVolume as true, the VM disk-image will be downloaded just once to create PreAllocatedDataVolume and VM Disks will be created by cloning over PreAllocatedDataVolume.
If the source is PVC-Clone, VM Disks will be created by cloning over custom-local-disks.
Which issue(s) this PR fixes:
Fixes #https://github.com/kubermatic/kubermatic/issues/11234
What type of PR is this?
/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Add HTTP source for KubeVirt VM Disk images which enables caching to avoid downloading images.
Documentation:
TBD
Signed-off-by: Sankalp Rangare [email protected]
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: sankalp-r
Once this PR has been reviewed and has the lgtm label, please assign ahmedwaleedmalik for approval by writing /assign @ahmedwaleedmalik in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
I am sorry @sankalp-r I have to block this PR, we have to do another brainstorming session
/hold
@sankalp-r: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-machine-controller-e2e-digitalocean | 842b0cb2b6c4fc48976b6b5bc56a17038fb4260d | link | true | /test pull-machine-controller-e2e-digitalocean |
| pull-machine-controller-e2e-azure | 842b0cb2b6c4fc48976b6b5bc56a17038fb4260d | link | true | /test pull-machine-controller-e2e-azure |
| pull-machine-controller-e2e-openstack | 842b0cb2b6c4fc48976b6b5bc56a17038fb4260d | link | true | /test pull-machine-controller-e2e-openstack |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ahmedwaleedmalik, mfranczy, sankalp-r
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/cloudprovider/provider/OWNERS~~ [ahmedwaleedmalik]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment