machine-controller
machine-controller copied to clipboard
kubermatic
Add support for OpenNebula as a cloud provider
What this PR does / why we need it:
This PR adds support for OpenNebula as a cloud provider. Similar to OpenStack it can be hosted on your own infrastructure.
We're using OpenNebula for many years already, and adding (basic?) support for it seemed to be easy enough.
What type of PR is this? /kind feature
Special notes for your reviewer: I'm not too fond of GoLang, so if there's anything that's not idiomatic please point it out.
Also I would still like to figure out automated end-to-end tests, any support with that is welcome. I tested it manually on a small kubernetes cluster (just some basic creation of the VMs) and it seems to work fine so far.
Does this PR introduce a user-facing change? Then add your Release Note here:
Add support for OpenNebula as a cloud provider
Documentation:
TBD
(?)
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: nilsding
To complete the pull request process, please assign ahmedwaleedmalik after the PR has been reviewed.
You can assign the PR to them by writing /assign @ahmedwaleedmalik in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @nilsding. Thanks for your PR.
I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hi,
we (adidas Runtastic) are testing this provider now for some month in some small user-clusters and it works fine for us. A review and approval would be much aprechiated @xrstf or @ahmedwaleedmalik - Thanks in advance!
Cheers, Andreas
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: embik, nilsding
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [embik]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest This bot automatically retries jobs that failed/flaked on approved PRs
Review the full test history
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.
/retest This bot automatically retries jobs that failed/flaked on approved PRs
Review the full test history
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.
/retest This bot automatically retries jobs that failed/flaked on approved PRs
Review the full test history
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.
/retest This bot automatically retries jobs that failed/flaked on approved PRs
Review the full test history
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.