docs icon indicating copy to clipboard operation
docs copied to clipboard

Update aws.en.md

Open hc2p opened this issue 1 year ago • 8 comments

Add missing "elasticloadbalancing:AddTags" permission.

hc2p avatar Nov 08 '23 16:11 hc2p

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign toschneck for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubermatic-bot avatar Nov 08 '23 16:11 kubermatic-bot

How does this relate to #1555?

xrstf avatar Nov 09 '23 12:11 xrstf

I was not aware of #1555 until now. This additional permission here was needed to provision AWS ELBs from a KKP 2.23.6 installation.

hc2p avatar Nov 09 '23 13:11 hc2p

Can you please add this to main and v2.24 for KKP docs as well?

embik avatar Nov 15 '23 10:11 embik

(Note that the file is _index.en.md in those newer docs versions.)

xrstf avatar Nov 15 '23 10:11 xrstf

Issues go stale after 90d of inactivity. After a furter 30 days, they will turn rotten. Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubermatic-bot avatar Feb 13 '24 12:02 kubermatic-bot

/remove-lifecycle stale

xrstf avatar Feb 13 '24 14:02 xrstf

Issues go stale after 90d of inactivity. After a furter 30 days, they will turn rotten. Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubermatic-bot avatar May 14 '24 02:05 kubermatic-bot

LGTM label has been added.

Git tree hash: dac6ed8007ec081c97d49c93d99c66533b2b448b

kubermatic-bot avatar Jul 30 '24 07:07 kubermatic-bot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubermatic-bot avatar Jul 30 '24 07:07 kubermatic-bot

@archups Thank you so, so much for this. Can we now close #1555 as well?

xrstf avatar Jul 30 '24 11:07 xrstf

@archups Thank you so, so much for this. Can we now close #1555 as well?

#1555 is addressing different issue fix. So IMO, update to the #1555 is required instead of closing it.

archups avatar Jul 30 '24 18:07 archups