docs icon indicating copy to clipboard operation
docs copied to clipboard

update kubevirt doc for topology spread constaint

Open sankalp-r opened this issue 2 years ago • 7 comments

Update kubevirt docs with TopologySpreadConstraint for VMs.

Signed-off-by: Sankalp Rangare [email protected]

sankalp-r avatar Sep 30 '22 09:09 sankalp-r

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sankalp-r

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubermatic-bot avatar Sep 30 '22 09:09 kubermatic-bot

Maybe we should wait for the UI to update the screenshots ? or do you plan to do a follow PR ?

hdurand0710 avatar Oct 17 '22 10:10 hdurand0710

Maybe we should wait for the UI to update the screenshots ? or do you plan to do a follow PR ?

yes, I will add the screenshots in follow-up PR after UI is ready.

sankalp-r avatar Oct 17 '22 10:10 sankalp-r

Maybe we should wait for the UI to update the screenshots ? or do you plan to do a follow PR ?

yes, I will add the screenshots in follow-up PR after UI is ready.

Ok, good then. We will also need an "upgrade" to KKP 2.22 section to describe the change to do in the MD for the deprecation (warning that it would spawn a new VM)

hdurand0710 avatar Oct 17 '22 10:10 hdurand0710

For the upgrade 2.21 to 2.22, do we already create a section like: https://docs.kubermatic.com/kubermatic/v2.21/tutorials-howtos/upgrading/upgrade-from-2.20-to-2.21/ ? Or add a section in this page containing the upgrade information, that we will move the to general section when creating the release ? Let's discuss this tomorrow.

hdurand0710 avatar Oct 17 '22 13:10 hdurand0710

We have to rephrase the section about compatibility.

/hold

mfranczy avatar Oct 25 '22 10:10 mfranczy

/retest

sankalp-r avatar Oct 27 '22 12:10 sankalp-r

/hold cancel

/retest

mfranczy avatar Nov 17 '22 13:11 mfranczy

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfranczy, sankalp-r

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [mfranczy,sankalp-r]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubermatic-bot avatar Nov 21 '22 19:11 kubermatic-bot

Do we want also to update https://docs.kubermatic.com/kubermatic/main/architecture/supported-providers/kubevirt/kubevirt/#kkp-machinedeployment-sample or maybe link to: https://github.com/kubermatic/machine-controller/blob/main/examples/kubevirt-machinedeployment.yaml to avoid changing this image each time ?

hdurand0710 avatar Nov 22 '22 09:11 hdurand0710

Do we want also to update https://docs.kubermatic.com/kubermatic/main/architecture/supported-providers/kubevirt/kubevirt/#kkp-machinedeployment-sample or maybe link to: https://github.com/kubermatic/machine-controller/blob/main/examples/kubevirt-machinedeployment.yaml to avoid changing this image each time ?

Updating it makes more sense, because if we add a link, then for the released-version, it will always point to the latest MC(main).

sankalp-r avatar Nov 22 '22 09:11 sankalp-r

/lgtm

hdurand0710 avatar Nov 23 '22 08:11 hdurand0710

LGTM label has been added.

Git tree hash: 178f85c63cf07729cfb186d8c8617ea57fbc27f8

kubermatic-bot avatar Nov 23 '22 08:11 kubermatic-bot