docs icon indicating copy to clipboard operation
docs copied to clipboard

Published 20 hours ago • verified publisher icon kubermatic

[WIP] Use content pages without versioning

Open serg opened this issue 2 years ago • 7 comments

serg avatar Aug 29 '22 13:08 serg

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: serg To complete the pull request process, please assign moadqassem after the PR has been reviewed. You can assign the PR to them by writing /assign @moadqassem in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubermatic-bot avatar Aug 29 '22 13:08 kubermatic-bot

@serg Is it possible to attach images of how this would look like in the Homepage and in the dedicated page?

moadqassem avatar Aug 29 '22 14:08 moadqassem

@moadqassem, for image we need to add logo field under operatingsystemmanager key inside data/products.yaml as for other products.

serg avatar Aug 30 '22 11:08 serg

@moadqassem, for image we need to add logo field under operatingsystemmanager key inside data/products.yaml as for other products.

@serg that should be possible since we already have the logo for OSM https://github.com/kubermatic/docs/blob/master/_content/operatingsystemmanager/master/img/operating-system-manager-logo.png

ahmedwaleedmalik avatar Aug 31 '22 11:08 ahmedwaleedmalik

Yes, but this image is huge in size and contain transparent spaces around actual content of the image. This image definitely should be minified and, possible, the whitespaces needs to be trimmed.

serg avatar Sep 06 '22 07:09 serg

@ahmedwaleedmalik I have added your image at this path /static/img/operatingsystemmanager/common/operating-system-manager-logo.png and reuse it in page content and on homepage.

serg avatar Oct 04 '22 11:10 serg

@serg let's merge this :D

ahmedwaleedmalik avatar Oct 30 '22 14:10 ahmedwaleedmalik

/assign @ahmedwaleedmalik

serg avatar Nov 28 '22 09:11 serg

LGTM label has been added.

Git tree hash: c5955c33d0973ac6b4f4f986390698a8b7a28152

kubermatic-bot avatar Nov 28 '22 09:11 kubermatic-bot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, serg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [ahmedwaleedmalik]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubermatic-bot avatar Nov 28 '22 10:11 kubermatic-bot