dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

Application Installation values modification fails

Open cnvergence opened this issue 1 year ago • 2 comments

What happened

When trying to modify the Cilium app values via the dashboard, it fails the validation with the following message

admission webhook "applicationinstallations.apps.kubermatic.k8c.io" denied the request: ApplicationInstallation validation request 12db5127-e0ec-4d4f-bc04-a582bf5de1e8 denied: [spec.values.cni: Invalid value: "null": value is immutable spec.values.ipam: Invalid value: "null": value is immutable spec.values.kubeProxyReplacement: Not found: "null" spec.values.operator: Invalid value: "null": value missing or incorrect spec.values.operator.securityContext: Invalid value: "null": value is immutable]

It seems that the modifications from the dashboard are only added to valuesBlock and the values are being emptied in https://github.com/kubermatic/dashboard/blob/2babca7f58eef0cd226aa6879416e6c4b9f1983c/modules/api/pkg/handler/v2/application_installation/application_installation.go#L247

When modifying Application Installation on that cluster directly, it works, so validation is working fine.

Expected behavior

Validation should be successful for allowed modifications via dashboard.

How to reproduce

Apply the sample from this issue https://github.com/kubermatic/kubermatic/issues/12923

Environment

  • UI Version: latest
  • API Version: latest

cnvergence avatar Apr 11 '24 07:04 cnvergence

Issues go stale after 90d of inactivity. After a furter 30 days, they will turn rotten. Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubermatic-bot avatar Jul 10 '24 14:07 kubermatic-bot

/remove-lifecycle stale

cnvergence avatar Jul 10 '24 16:07 cnvergence