WIP: Support for OpenStack server groups
Signed-off-by: Waleed Malik [email protected]
What this PR does / why we need it: API and frontend support for assigning server groups for OpenStack Machines.
Which issue(s) this PR fixes:
Fixes #5200 xref https://github.com/kubermatic/kubermatic/issues/8827
What type of PR is this?
/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Support for using server groups with OpenStack
Documentation:
NONE
Codecov Report
Merging #5201 (fb8654d) into main (a02a90f) will decrease coverage by
0.10%. The diff coverage is2.77%.
@@ Coverage Diff @@
## main #5201 +/- ##
==========================================
- Coverage 48.40% 48.30% -0.11%
==========================================
Files 398 398
Lines 15227 15265 +38
Branches 2709 2721 +12
==========================================
+ Hits 7371 7374 +3
- Misses 7407 7437 +30
- Partials 449 454 +5
| Impacted Files | Coverage Δ | |
|---|---|---|
| .../app/core/services/node-data/provider/openstack.ts | 13.88% <0.00%> (-4.98%) |
:arrow_down: |
| src/app/core/services/provider/openstack.ts | 40.00% <0.00%> (-10.00%) |
:arrow_down: |
| src/app/shared/entity/node.ts | 18.42% <ø> (ø) |
|
| src/app/core/services/wizard/provider/openstack.ts | 60.89% <7.14%> (-5.30%) |
:arrow_down: |
| src/app/shared/validators/others.ts | 100.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update a02a90f...fb8654d. Read the comment docs.
@ahmedwaleedmalik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pre-dashboard-test-e2e | fb8654d45502ad6d3a0938c1a157b3c735aaf46b | link | false | /test pre-dashboard-test-e2e |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
/approve just checked the API part
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ahmedwaleedmalik, lsviben
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~cmd/kubermatic-api/OWNERS~~ [ahmedwaleedmalik,lsviben]
- ~~pkg/OWNERS~~ [ahmedwaleedmalik,lsviben]
- ~~pkg/api/OWNERS~~ [ahmedwaleedmalik,lsviben]
- ~~pkg/handler/OWNERS~~ [ahmedwaleedmalik,lsviben]
- ~~src/OWNERS~~ [ahmedwaleedmalik]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
LGTM label has been added.