dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

Limit Data When Listing AppDefs and AppInstalls

Open SimonTheLeg opened this issue 1 year ago • 3 comments

Signed-off-by: Simon Bein [email protected]

What this PR does / why we need it:

This PR is migrated from https://github.com/kubermatic/kubermatic/pull/11005. Please see the original PR for all discussion

Which issue(s) this PR fixes:

Fixes https://github.com/kubermatic/kubermatic/issues/10406

What type of PR is this?

Special notes for your reviewer: /kind cleanup

Does this PR introduce a user-facing change? Then add your Release Note here:

- Limit Data When Listing AppDefs and AppInstalls
- Add GET endpoint for AppDefs

Documentation:

NONE

SimonTheLeg avatar Nov 01 '22 16:11 SimonTheLeg

Codecov Report

Merging #5184 (ff09808) into main (b1f5d0c) will decrease coverage by 0.32%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5184      +/-   ##
==========================================
- Coverage   48.30%   47.98%   -0.33%     
==========================================
  Files         398      398              
  Lines       15265    15387     +122     
  Branches     2721     2758      +37     
==========================================
+ Hits         7374     7383       +9     
- Misses       7437     7540     +103     
- Partials      454      464      +10     
Impacted Files Coverage Δ
src/app/core/services/external-cluster.ts 8.78% <0.00%> (-2.43%) :arrow_down:
...rnal-cluster-credentials/provider/eks/component.ts 17.00% <0.00%> (-0.98%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b1f5d0c...ff09808. Read the comment docs.

codecov[bot] avatar Nov 01 '22 16:11 codecov[bot]

@vgramer all changes done. PR is ready for approval

SimonTheLeg avatar Nov 07 '22 15:11 SimonTheLeg

LGTM label has been added.

Git tree hash: 8cfc1807e0e80996fa5a812b714a8d80866bf365

kubermatic-bot avatar Nov 08 '22 08:11 kubermatic-bot

/approve

pkprzekwas avatar Nov 08 '22 08:11 pkprzekwas

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pkprzekwas, SimonTheLeg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubermatic-bot avatar Nov 08 '22 08:11 kubermatic-bot