kuberhealthy icon indicating copy to clipboard operation
kuberhealthy copied to clipboard

Add status to khcheck and khjob

Open ugurzongur opened this issue 2 years ago • 1 comments

Fixes #1120

After changing the types.go files for khjob and khcheck, I manually edited pkg/apis/khjob/v1/kuberhealthyjob.go and pkg/apis/khcheck/v1/kuberhealthycheck.go files respectively because I couldn't replicate the method that was used to generate those files. This is also mentioned in #1055. I tried current and older versions of https://github.com/kubernetes/code-generator with various parameters but they all ended up being quite different from the existing files especially in terms of folder structure. I believe those files are a combination of auto-generation and post-editing. IMHO that needs to be fixed eventually.

ugurzongur avatar May 02 '23 16:05 ugurzongur

@ugurzongur How can we get this change merged?

LS80 avatar Jun 13 '23 16:06 LS80

😞

LS80 avatar Mar 21 '24 10:03 LS80