kuberhealthy icon indicating copy to clipboard operation
kuberhealthy copied to clipboard

Published 20 hours ago • verified publisher icon kuberhealthy

Custom Metadata inside health state

Open povils opened this issue 2 years ago • 2 comments

Add custom Metadata to Health State (solves #1071)

povils avatar Jun 12 '22 21:06 povils

You did a lot of great stuff here, and thank you for that! I feel like a prefixed environment variable might be a little messy and confusing to implement. What do you think about implementing these variables instead as a map in the configmap?

The configmap is here. We could put a map[string]string in here that gets placed in the status page output if present. That would avoid all the prefix parsing and the slightly confusing pattern of prefixing your metadata as environment variables.

Thoughts?

integrii avatar Jun 12 '22 23:06 integrii

@integrii I think it is indeed better, I updated the PR :)

povils avatar Jun 14 '22 08:06 povils

@povils there were build fixes in master. Can you merge the latest master and push it to your branch please? That should make builds pass on this branch...

integrii avatar Oct 17 '22 16:10 integrii

How about report by /externalCheckStatus:

https://github.com/kuberhealthy/kuberhealthy/blob/b489fb6fba14ec054fddc1cf18d0f29658cec6cd/pkg/checks/external/status/main.go#L1-L26

Should we support to add metadata there?

fungaren avatar Jul 11 '23 10:07 fungaren

Merged in #1158

integrii avatar Nov 05 '23 00:11 integrii